Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NC | Pass noobaa args to GPFS on initialization #8116

Merged
merged 1 commit into from
Jun 9, 2024
Merged

NC | Pass noobaa args to GPFS on initialization #8116

merged 1 commit into from
Jun 9, 2024

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Jun 6, 2024 •
edited
Loading

Explain the changes

  1. Added a new function called register_gpfs_noobaa() that calls gpfs_ganesha(157, noobaa_args) function (a gpfs function) in order to register NooBaa process and pass the following args -
    { int noobaa_version, int noobaa_delay, int noobaa_flags }, currently version and flags are set to 0, delay is configurable by a new configuration called GPFS_DOWN_DELAY.
    noobaa_delay = delay (ms) of GPFS syscalls when daemon is down, to hold client replies during failover.
  2. nsfs.js calls register_gpfs_noobaa() from verify_gpfs_lib() fucntion from the primary noobaa process.

Issues: Fixed #xxx / Gap #xxx

  1. Fixed NSFS endpoint should set its process/threads name in the OS to be identified accurately #8049

Testing Instructions:

  1. Install NooBaa RPM
  2. Start noobaa service
  3. Start io and check the calling processes and threads (in GPFS) called NooBaa.
  4. Change the delay by editing GPFS_DOWN_DELAY=60000 in config.json.
  5. Restart the service
  6. Check the updated delay.
  • Doc added/updated
  • Tests added

guymguym
guymguym reviewed Jun 6, 2024
View reviewed changes
src/native/fs/fs_napi.cpp Outdated Show resolved Hide resolved
src/native/fs/fs_napi.cpp Outdated Show resolved Hide resolved
src/server/system_services/schemas/nsfs_config_schema.js Outdated Show resolved Hide resolved
src/native/fs/fs_napi.cpp Outdated Show resolved Hide resolved
docs/dev_guide/NonContainerizedDeveloperCustomizations.md Outdated Show resolved Hide resolved
@romayalon romayalon force-pushed the romy-native-process-name branch 2 times, most recently from 6bc1c5e to b8bd032 Compare June 6, 2024 20:08
@romayalon romayalon marked this pull request as ready for review June 6, 2024 20:10
@romayalon romayalon force-pushed the romy-native-process-name branch from b8bd032 to b8b6b24 Compare June 6, 2024 20:43
guymguym
guymguym reviewed Jun 6, 2024
View reviewed changes
src/native/fs/fs_napi.cpp Outdated Show resolved Hide resolved
src/native/fs/fs_napi.cpp Outdated Show resolved Hide resolved
src/sdk/nb.d.ts Outdated Show resolved Hide resolved
src/cmd/nsfs.js Outdated Show resolved Hide resolved
@romayalon romayalon force-pushed the romy-native-process-name branch from b8b6b24 to a1afed8 Compare June 9, 2024 06:56
guymguym
guymguym reviewed Jun 9, 2024
View reviewed changes
src/native/fs/fs_napi.cpp Outdated Show resolved Hide resolved
src/native/fs/fs_napi.cpp Outdated Show resolved Hide resolved
src/native/fs/fs_napi.cpp Outdated Show resolved Hide resolved
@guymguym
Copy link
Member

guymguym commented Jun 9, 2024

@romayalon can you update the PR description too?

@romayalon romayalon force-pushed the romy-native-process-name branch from a1afed8 to b1bc823 Compare June 9, 2024 08:07
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jun 9, 2024
guymguym
guymguym reviewed Jun 9, 2024
View reviewed changes
src/native/fs/fs_napi.cpp Outdated Show resolved Hide resolved
guymguym
guymguym reviewed Jun 9, 2024
View reviewed changes
src/native/fs/fs_napi.cpp Outdated Show resolved Hide resolved
@romayalon romayalon force-pushed the romy-native-process-name branch from b1bc823 to 2dce3b2 Compare June 9, 2024 08:59
@romayalon romayalon requested a review from guymguym June 9, 2024 09:16
@romayalon romayalon changed the title DRAFT | NC | Pass noobaa args to GPFS on initialization NC | Pass noobaa args to GPFS on initialization Jun 9, 2024
@romayalon romayalon force-pushed the romy-native-process-name branch from 2dce3b2 to eb908b0 Compare June 9, 2024 09:31
@romayalon romayalon requested review from guymguym and removed request for guymguym June 9, 2024 10:53
@romayalon
NC | pass noobaa args to gpfs
1dfcf85 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon force-pushed the romy-native-process-name branch from eb908b0 to 1dfcf85 Compare June 9, 2024 13:19
@romayalon romayalon merged commit 0f75558 into noobaa:master Jun 9, 2024
10 checks passed
This was referenced Jun 9, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guymguym guymguym guymguym approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NSFS endpoint should set its process/threads name in the OS to be identified accurately
2 participants
@romayalon @guymguym